Enhancements to loadbalancer #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having Publishers return a set of endpoints directly (synchronously) allows us to eliminate a lot of boilerplate related to pub/sub semantics, as well as the cache type. Thanks, @rogpeppe!
peterbourgon
changed the title
|
@rogpeppe Thanks for your suggestions at GopherCon. I've changed the package and API and it feels a lot smoother. Have a few moments for a quick code review? |
| } | ||
| ``` | ||
|
|
||
| It's also possible to wrap a load balancer with a retry strategy, so that it | ||
| can used as an endpoint directly. This may make load balancers more convenient |
If the publisher has been stopped, return an appropriate error message from Endpoints. Thanks, @ChrisHines!
| // Get a new endpoint from the load balancer. | ||
| endpoint, err := lb.Endpoint() | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
shouldn't just loop until we have a valid endpoint after waiting few seconds ?
There was a problem hiding this comment.
If your DNS name has no instances, I believe it's much better to crash your program on startup, than to successfully start up, but leave you in a state where you can't complete any requests.
There was a problem hiding this comment.
I've been thinking about this and may revisit this decision...
peterbourgon
added a commit
that referenced
this pull request
Aug 6, 2015
Enhancements to loadbalancer
This was referenced Aug 7, 2015
guycook
pushed a commit
to codelingo/kit
that referenced
this pull request
Oct 12, 2016
Enhancements to loadbalancer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #73 and #83.