Add Windows Eventlog logger #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 22, 2023
jkroepke
force-pushed
the
eventlog
branch
5 times, most recently
from
9510a57
to
7a756c8
Compare
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
|
My intuition is that Windows Event Logs are out-of-scope for the core go-kit/log package. |
|
I saw the syslog package here and though it might be good idea to have the windows counterpart as well here. |
|
@peterbourgon I cant reproduce the errors from CI. Could it be possible that the version latest is to new for the go version 1.16-1.18? I got no output. Please let me know, if you want to have this in scope of go-kit/log or not. |
|
Realistically, I cannot maintain this patch in the core module, as I have no direct access to a Windows machine. I think it would be better if this were available in a separate repository. |
|
Alright. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the syslog package.
Useful for golang applications running on Windows.
go does not provide a way to read or fetch Windows Event Logs. The tests are limited to sending only, but can't check if the log entry is present.
Tested on a real Windows machine.