Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer errors for all iterators #619

Merged
merged 6 commits into from
May 16, 2023
Merged

Defer errors for all iterators #619

merged 6 commits into from
May 16, 2023

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented May 16, 2023

Fixes #616

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 96.87% and project coverage change: +0.33 🎉

Comparison is base (51b82d6) 92.13% compared to head (67fbd80) 92.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
+ Coverage   92.13%   92.47%   +0.33%     
==========================================
  Files          21       21              
  Lines        1323     1329       +6     
==========================================
+ Hits         1219     1229      +10     
+ Misses         78       76       -2     
+ Partials       26       24       -2     
Impacted Files Coverage Δ
bulk.go 97.14% <88.88%> (+5.96%) ⬆️
changes.go 100.00% <100.00%> (ø)
iterator.go 97.70% <100.00%> (+0.11%) ⬆️
resultset.go 76.64% <100.00%> (ø)
updates.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@flimzy flimzy merged commit 1cc8f98 into master May 16, 2023
3 checks passed
@flimzy flimzy deleted the updatesErr branch May 16, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all iterators to defer errors and update any other semantics
1 participant