Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BulkDocs to no longer return an iterator #623

Merged
merged 3 commits into from
May 18, 2023
Merged

Update BulkDocs to no longer return an iterator #623

merged 3 commits into from
May 18, 2023

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented May 17, 2023

Fixes #557

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (1cc8f98) 92.47% compared to head (d05e948) 92.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
- Coverage   92.47%   92.46%   -0.01%     
==========================================
  Files          21       21              
  Lines        1329     1301      -28     
==========================================
- Hits         1229     1203      -26     
+ Misses         76       75       -1     
+ Partials       24       23       -1     
Impacted Files Coverage Δ
driver/driver.go 100.00% <ø> (ø)
bulk.go 100.00% <100.00%> (+2.85%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@flimzy flimzy merged commit 9cd0acd into master May 18, 2023
2 of 3 checks passed
@flimzy flimzy deleted the bulkdocs branch May 18, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider simplifying BulkResults
1 participant