Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass rev as options to driver instances #624

Merged
merged 2 commits into from
May 19, 2023
Merged

Pass rev as options to driver instances #624

merged 2 commits into from
May 19, 2023

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented May 18, 2023

Fixes #523

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (9cd0acd) 92.46% compared to head (772c3e3) 92.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   92.46%   92.44%   -0.03%     
==========================================
  Files          21       21              
  Lines        1301     1297       -4     
==========================================
- Hits         1203     1199       -4     
  Misses         75       75              
  Partials       23       23              
Impacted Files Coverage Δ
driver/driver.go 100.00% <ø> (ø)
db.go 95.39% <100.00%> (-0.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@flimzy flimzy merged commit 8758986 into master May 19, 2023
3 checks passed
@flimzy flimzy deleted the driverrev branch May 19, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing 'rev' argument from driver methods
1 participant