Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split underlying resultsets into two types: basic and full #639

Merged
merged 8 commits into from
Aug 14, 2023

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Aug 14, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 54.54% and project coverage change: +0.08% 🎉

Comparison is base (a35635b) 90.62% compared to head (4d62a64) 90.70%.

❗ Current head 4d62a64 differs from pull request most recent head edfde59. Consider uploading reports for the commit edfde59 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
+ Coverage   90.62%   90.70%   +0.08%     
==========================================
  Files          21       21              
  Lines        1344     1345       +1     
==========================================
+ Hits         1218     1220       +2     
+ Misses         99       98       -1     
  Partials       27       27              
Files Changed Coverage Δ
row.go 35.29% <ø> (+12.21%) ⬆️
resultset.go 66.48% <40.00%> (-2.71%) ⬇️
db.go 95.41% <100.00%> (ø)
find.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit 91f33cb into master Aug 14, 2023
@flimzy flimzy deleted the basicResultSet branch August 14, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant