Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Security/SetSecurity optional for a backend #670

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Sep 2, 2023

Fixes #632

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.06% ⚠️

Comparison is base (bedbff9) 88.44% compared to head (6660530) 88.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   88.44%   88.38%   -0.06%     
==========================================
  Files          62       62              
  Lines        5832     5838       +6     
==========================================
+ Hits         5158     5160       +2     
- Misses        569      571       +2     
- Partials      105      107       +2     
Files Changed Coverage Δ
driver/driver.go 100.00% <ø> (ø)
db.go 94.13% <50.00%> (-0.91%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit ac8bcec into master Sep 2, 2023
1 of 3 checks passed
@flimzy flimzy deleted the securityIface branch September 2, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Security/SetSecurity optional features for a driver to implement
1 participant