Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert options to function arguments #679

Merged
merged 43 commits into from
Sep 12, 2023
Merged

Convert options to function arguments #679

merged 43 commits into from
Sep 12, 2023

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Sep 6, 2023

Alternative implementation of #673

@flimzy flimzy force-pushed the options branch 3 times, most recently from 384d86b to e0f5f58 Compare September 6, 2023 09:57
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 73.54% and project coverage change: +0.04% 🎉

Comparison is base (a28a046) 82.88% compared to head (611a43e) 82.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
+ Coverage   82.88%   82.93%   +0.04%     
==========================================
  Files          83       85       +2     
  Lines        9003     9022      +19     
==========================================
+ Hits         7462     7482      +20     
+ Misses       1331     1329       -2     
- Partials      210      211       +1     
Files Changed Coverage Δ
couchdb/chttp/options.go 0.00% <0.00%> (-64.52%) ⬇️
couchdb/test/session.go 0.74% <0.00%> (ø)
driver/driver.go 100.00% <ø> (ø)
options.go 27.27% <27.27%> (ø)
mockdb/gen/render.go 54.27% <46.15%> (-1.41%) ⬇️
mockdb/dbexpectations_gen.go 65.95% <57.58%> (+3.44%) ⬆️
mockdb/clientexpectations_gen.go 61.26% <69.36%> (+1.99%) ⬆️
couchdb/options.go 71.42% <71.42%> (ø)
mockdb/common.go 80.00% <77.77%> (-0.77%) ⬇️
couchdb/db.go 80.24% <81.48%> (-0.36%) ⬇️
... and 27 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy force-pushed the options branch 26 times, most recently from 644c932 to 8dfbfa7 Compare September 7, 2023 21:18
@flimzy flimzy merged commit 891e327 into master Sep 12, 2023
2 of 3 checks passed
@flimzy flimzy deleted the options branch September 12, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant