Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert authentication to options #708

Merged
merged 13 commits into from
Sep 14, 2023
Merged

Convert authentication to options #708

merged 13 commits into from
Sep 14, 2023

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Sep 13, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 60.46% and project coverage change: -0.36% ⚠️

Comparison is base (588781b) 82.94% compared to head (80dd38b) 82.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
- Coverage   82.94%   82.59%   -0.36%     
==========================================
  Files          85       84       -1     
  Lines        9035     8996      -39     
==========================================
- Hits         7494     7430      -64     
- Misses       1331     1358      +27     
+ Partials      210      208       -2     
Files Changed Coverage Δ
driver/driver.go 100.00% <ø> (ø)
kivik.go 100.00% <ø> (ø)
mockdb/client.go 88.23% <ø> (-2.25%) ⬇️
mockdb/clientmock.go 94.39% <ø> (-0.21%) ⬇️
mockdb/expectations.go 96.92% <ø> (-0.34%) ⬇️
mockdb/gen/main.go 30.88% <ø> (ø)
couchdb/chttp/proxyauth.go 50.00% <23.07%> (-18.00%) ⬇️
couchdb/chttp/options.go 21.15% <52.38%> (+21.15%) ⬆️
couchdb/chttp/basicauth.go 77.14% <61.90%> (-22.86%) ⬇️
couchdb/chttp/chttp.go 97.04% <66.66%> (+1.39%) ⬆️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy force-pushed the authOpts branch 3 times, most recently from e79a3c3 to b9dc65b Compare September 14, 2023 08:18
@flimzy flimzy changed the title Make CookieAuth work as a kivik.Option Convert authentication to options Sep 14, 2023
@flimzy flimzy merged commit 1348f84 into master Sep 14, 2023
1 of 3 checks passed
@flimzy flimzy deleted the authOpts branch September 14, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant