Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 bugs in readRev: #728

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix 2 bugs in readRev: #728

merged 1 commit into from
Sep 18, 2023

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Sep 18, 2023

  • Composite values before _rev were parsed token-by-token, rather than discarding the entire value
  • A value of "_rev" would have confused it

- Composite values before `_rev` were parsed token-by-token, rather than discarding the entire value
- A value of `"_rev"` would have confused it
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.02% ⚠️

Comparison is base (102b906) 82.50% compared to head (79af993) 82.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
- Coverage   82.50%   82.49%   -0.02%     
==========================================
  Files          85       85              
  Lines        9009     9012       +3     
==========================================
+ Hits         7433     7434       +1     
- Misses       1368     1369       +1     
- Partials      208      209       +1     
Files Changed Coverage Δ
couchdb/chttp/chttp.go 96.35% <33.33%> (-0.70%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit a2f131f into master Sep 18, 2023
1 of 3 checks passed
@flimzy flimzy deleted the readRev_bugs branch September 18, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant