Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch other backends to use new getter interface #764

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Sep 25, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.12% ⚠️

Comparison is base (a79e11f) 79.33% compared to head (3ff3c4e) 79.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
- Coverage   79.33%   79.21%   -0.12%     
==========================================
  Files         165      165              
  Lines       12940    12954      +14     
==========================================
- Hits        10266    10262       -4     
- Misses       2235     2252      +17     
- Partials      439      440       +1     
Files Changed Coverage Δ
driver/driver.go 100.00% <ø> (ø)
mockdb/gen/main.go 30.88% <ø> (ø)
x/fsdb/get.go 65.71% <52.94%> (-14.29%) ⬇️
x/memorydb/db.go 71.15% <55.55%> (-4.13%) ⬇️
db.go 94.43% <100.00%> (+0.26%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit 85ced49 into master Sep 25, 2023
1 of 3 checks passed
@flimzy flimzy deleted the oldInterfaceCleanup branch September 25, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant