Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the ResultSet implementation #774

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Simplify the ResultSet implementation #774

merged 2 commits into from
Sep 26, 2023

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Sep 26, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (03ec484) 79.60% compared to head (8ca75cf) 79.65%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   79.60%   79.65%   +0.04%     
==========================================
  Files         167      167              
  Lines       13180    13170      -10     
==========================================
- Hits        10492    10490       -2     
+ Misses       2245     2237       -8     
  Partials      443      443              
Files Coverage Δ
rows.go 77.10% <ø> (ø)
resultset.go 71.17% <40.00%> (+4.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit dbcde13 into master Sep 26, 2023
2 of 3 checks passed
@flimzy flimzy deleted the resultSetSimplify branch September 26, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant