Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further simplify the ResultSet implementation #777

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Sep 26, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b7ab059) 79.65% compared to head (ac038c8) 79.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
+ Coverage   79.65%   79.77%   +0.11%     
==========================================
  Files         167      167              
  Lines       13170    13149      -21     
==========================================
- Hits        10490    10489       -1     
+ Misses       2237     2223      -14     
+ Partials      443      437       -6     
Files Coverage Δ
find.go 100.00% <100.00%> (ø)
iterator.go 97.77% <100.00%> (+0.07%) ⬆️
resultset.go 86.20% <ø> (+15.03%) ⬆️
db.go 94.43% <92.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit 5bf0fb0 into master Sep 27, 2023
3 checks passed
@flimzy flimzy deleted the resultSetSimplify2 branch September 27, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant