Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More simplification of the ResultSet implementation #783

Merged
merged 9 commits into from
Sep 28, 2023

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Sep 28, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (ac038c8) 79.77% compared to head (e1d7e1c) 79.80%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   79.77%   79.80%   +0.03%     
==========================================
  Files         167      166       -1     
  Lines       13149    13131      -18     
==========================================
- Hits        10489    10479      -10     
+ Misses       2223     2215       -8     
  Partials      437      437              
Files Coverage Δ
find.go 100.00% <100.00%> (ø)
db.go 94.43% <93.75%> (ø)
resultset.go 84.86% <78.65%> (-1.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit e0de5c6 into master Sep 28, 2023
3 checks passed
@flimzy flimzy deleted the resultSetSimplify3 branch September 28, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant