Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constants in place of error variables #814

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Use constants in place of error variables #814

merged 3 commits into from
Oct 11, 2023

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Oct 11, 2023

Fixes #805

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (50c091b) 78.98% compared to head (bd6ce10) 78.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage   78.98%   78.96%   -0.03%     
==========================================
  Files         166      166              
  Lines       13341    13333       -8     
==========================================
- Hits        10538    10528      -10     
- Misses       2364     2366       +2     
  Partials      439      439              
Files Coverage Δ
cluster.go 100.00% <100.00%> (ø)
config.go 100.00% <100.00%> (ø)
errors.go 100.00% <ø> (+14.28%) ⬆️
find.go 100.00% <100.00%> (ø)
replication.go 100.00% <100.00%> (ø)
db.go 93.43% <33.33%> (ø)
internal/errors.go 21.73% <0.00%> (-1.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit 58b756a into master Oct 11, 2023
1 of 3 checks passed
@flimzy flimzy deleted the constErrors branch October 11, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace variable errors with constants
1 participant