Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the single-doc operating mode of the resultset #819

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Oct 11, 2023

Fixes #812

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (055b99d) 78.93% compared to head (77cada0) 78.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
- Coverage   78.93%   78.87%   -0.07%     
==========================================
  Files         166      166              
  Lines       13345    13339       -6     
==========================================
- Hits        10534    10521      -13     
- Misses       2371     2383      +12     
+ Partials      440      435       -5     
Files Coverage Δ
db.go 92.68% <ø> (ø)
resultset.go 76.96% <62.50%> (-4.56%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit bad77c7 into master Oct 12, 2023
1 of 3 checks passed
@flimzy flimzy deleted the unmakeReady branch October 12, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove makeReady functionality
1 participant