Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin adding attachments support #888

Merged
merged 15 commits into from
Feb 19, 2024
Merged

Begin adding attachments support #888

merged 15 commits into from
Feb 19, 2024

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Feb 18, 2024

This handles most cases, but there are a few corner cases still to test for and maybe add support for.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (3f875c1) 63.63% compared to head (246a804) 63.81%.

Files Patch % Lines
x/sqlite/get.go 88.43% 24 Missing and 13 partials ⚠️
x/sqlite/put.go 81.92% 15 Missing and 15 partials ⚠️
x/sqlite/json.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
+ Coverage   63.63%   63.81%   +0.17%     
==========================================
  Files         287      290       +3     
  Lines       19223    19381     +158     
==========================================
+ Hits        12233    12368     +135     
- Misses       6417     6433      +16     
- Partials      573      580       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit 04c8c69 into master Feb 19, 2024
3 checks passed
@flimzy flimzy deleted the attachments branch February 19, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant