Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulate CreateDoc if not implemented by backend #896

Merged
merged 3 commits into from
Feb 24, 2024
Merged

Emulate CreateDoc if not implemented by backend #896

merged 3 commits into from
Feb 24, 2024

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Feb 24, 2024

This moves the CreateDoc implementation from each backend, into a single implementation in the frontend.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 64.04%. Comparing base (b8d1f63) to head (9a45baa).

Files Patch % Lines
db.go 81.81% 1 Missing and 1 partial ⚠️
internal/mock/db.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   64.03%   64.04%   +0.01%     
==========================================
  Files         293      293              
  Lines       19519    19511       -8     
==========================================
- Hits        12499    12496       -3     
+ Misses       6441     6438       -3     
+ Partials      579      577       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit 0388fde into master Feb 24, 2024
3 checks passed
@flimzy flimzy deleted the createDoc branch February 24, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant