Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginning of delete attachment support #898

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Beginning of delete attachment support #898

merged 6 commits into from
Mar 4, 2024

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Mar 1, 2024

No description provided.

@flimzy flimzy merged commit 6d26097 into master Mar 4, 2024
1 check passed
@flimzy flimzy deleted the putattachment2 branch March 4, 2024 13:46
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 79.41176% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 64.13%. Comparing base (9022b7d) to head (bd45947).
Report is 7 commits behind head on master.

Files Patch % Lines
x/sqlite/deleteattachment.go 66.66% 4 Missing and 1 partial ⚠️
x/sqlite/util.go 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
+ Coverage   64.11%   64.13%   +0.01%     
==========================================
  Files         294      295       +1     
  Lines       19564    19582      +18     
==========================================
+ Hits        12543    12558      +15     
- Misses       6440     6442       +2     
- Partials      581      582       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant