Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to GetAttachment, Delete and DeleteAttachment #911

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Mar 28, 2024

No description provided.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 87.01299% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 64.28%. Comparing base (2d5f77e) to head (aa71cf2).

Files Patch % Lines
x/sqlite/deleteattachment.go 77.77% 3 Missing and 1 partial ⚠️
x/sqlite/util.go 73.33% 2 Missing and 2 partials ⚠️
x/sqlite/delete.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
+ Coverage   64.21%   64.28%   +0.07%     
==========================================
  Files         297      297              
  Lines       19643    19705      +62     
==========================================
+ Hits        12613    12668      +55     
- Misses       6444     6447       +3     
- Partials      586      590       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit cb213f0 into master Mar 28, 2024
3 checks passed
@flimzy flimzy deleted the getAttachment2 branch March 28, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant