Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginning support for querying views #944

Merged
merged 11 commits into from
Apr 18, 2024
Merged

Beginning support for querying views #944

merged 11 commits into from
Apr 18, 2024

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Apr 17, 2024

No description provided.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 77.36842% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 65.36%. Comparing base (e2287f0) to head (9cb17e8).

Files Patch % Lines
x/sqlite/query.go 75.39% 16 Missing and 15 partials ⚠️
x/sqlite/logging.go 0.00% 5 Missing ⚠️
x/sqlite/json.go 55.55% 2 Missing and 2 partials ⚠️
x/sqlite/options.go 88.88% 2 Missing ⚠️
x/sqlite/views.go 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #944      +/-   ##
==========================================
+ Coverage   65.26%   65.36%   +0.09%     
==========================================
  Files         304      306       +2     
  Lines       20836    21002     +166     
==========================================
+ Hits        13599    13727     +128     
- Misses       6589     6610      +21     
- Partials      648      665      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit 174a241 into master Apr 18, 2024
3 checks passed
@flimzy flimzy deleted the Query branch April 18, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant