Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http client 有里 bug #10

Closed
gggwvg opened this issue Apr 12, 2019 · 4 comments
Closed

http client 有里 bug #10

gggwvg opened this issue Apr 12, 2019 · 4 comments

Comments

@gggwvg
Copy link

gggwvg commented Apr 12, 2019

https://github.com/bilibili/kratos/blob/50d0129461492015a987f640136c199f9f9753e8/pkg/net/http/blademaster/client.go#L140

如果有参数,uri 和 params.Encode() 中间少了个 ?

@XyuWang
Copy link
Contributor

XyuWang commented Apr 12, 2019

快回来修 座位还给你留着呢

@longXboy
Copy link
Member

确实是bug,我们修复一下,感谢大佬反馈

@beordle
Copy link

beordle commented Apr 23, 2019

哈哈哈,是不是楼主自己写的啊

@lintanghui
Copy link
Contributor

已修复

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants