Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: parsing config input and convert to match the type #3306

Merged
merged 1 commit into from
Jun 15, 2024
Merged

feat: parsing config input and convert to match the type #3306

merged 1 commit into from
Jun 15, 2024

Conversation

akoserwal
Copy link
Contributor

@akoserwal akoserwal commented Apr 26, 2024 •
edited

Description (what this PR does / why we need it):

Convert to type based on the followed pattern:

  • bool: true/false
  • float64: has(.) parseFloat
  • int64: parseInt
  • string: default
  • ${key:"defaultValue"}

fix: #3198

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 26, 2024
@akoserwal
Copy link
Contributor Author

@@shenqidebaozi Please review

@shenqidebaozi
Copy link
Sponsor Member

shenqidebaozi commented Apr 30, 2024 •
edited

@akoserwal Okay, no problem. Let me find some more people to watch together @go-kratos/contributor

shenqidebaozi
shenqidebaozi reviewed Apr 30, 2024
View reviewed changes
config/options.go Outdated Show resolved Hide resolved
@akoserwal akoserwal force-pushed the fix-config-parsing branch 3 times, most recently from 48bfca4 to 2ad825d Compare May 6, 2024 09:23
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 6, 2024
@shenqidebaozi shenqidebaozi changed the title fix: parsing config input and convert to match the type feat: parsing config input and convert to match the type Jun 1, 2024
@dosubot dosubot bot added the LGTM label Jun 1, 2024
@shenqidebaozi shenqidebaozi merged commit 46362d1 into go-kratos:main Jun 15, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenqidebaozi shenqidebaozi shenqidebaozi approved these changes

@daemon365 daemon365 daemon365 approved these changes

Assignees
No one assigned
Labels
LGTM size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with configuration file to render the values from environment variables
3 participants
@akoserwal @shenqidebaozi @daemon365