Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

Add a couple of nil function implementations. #47

Merged
merged 1 commit into from
Sep 24, 2013

Conversation

quarnster
Copy link
Contributor

This makes a simple fmt.Println based hello world compile and link, although interestingly enough nothing is printed out to the console when running it.

Is there a straightforward way to build Go's test suite using llgo?

Also a heads up that llgo-dist will not succeed with the latest tip of go types.

axw added a commit that referenced this pull request Sep 24, 2013
Add a couple of nil function implementations.
@axw axw merged commit 94084df into go-llvm:master Sep 24, 2013
@axw
Copy link
Member

axw commented Sep 24, 2013

This makes a simple fmt.Println based hello world compile and link, although interestingly enough nothing is printed out to the console when running it.

Hrm. Well, fmt.Println works on Linux x86-64, but I'm not building against tip. I'll try building against tip (probably tomorrow).

Is there a straightforward way to build Go's test suite using llgo?

No, but that's something I'd really like to have. At the moment, I don't regularly build/run the standard Go tests, though I have tested quite a few of them at one time or another.

Also a heads up that llgo-dist will not succeed with the latest tip of go types.

Thanks, I've updated to the latest go/types.

@axw
Copy link
Member

axw commented Sep 25, 2013

FYI, fmt.Println works fine in my Linux environment.

@axw
Copy link
Member

axw commented Sep 25, 2013

So, looking closer, it appears that the syscall code for Darwin is wrong (just a copy of the Linux one?)
From a glance over asm_darwin_amd64.s from gc, it looks like the syscall number needs to be offset by a constant; and the result/error check comparison is wrong.

@quarnster
Copy link
Contributor Author

Yes, it was just a copy to make it compile/link, haven't looked closer at that yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants