Skip to content

Commit

Permalink
Merge pull request #7 from go-logr/level-field
Browse files Browse the repository at this point in the history
Not mutate global zerolog.LevelFieldName
  • Loading branch information
thockin committed Nov 22, 2021
2 parents 5a64b15 + ba6c7fd commit 92a2ed7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
10 changes: 5 additions & 5 deletions example/example_test.go
Expand Up @@ -58,9 +58,9 @@ func ExampleNew() {
Helper(log, "thru a helper")

// Output:
// {"module":"example","v":0,"logger":"MyName","val1":1,"val2":{"k":1},"message":"hello"}
// {"module":"example","v":1,"logger":"MyName","message":"you should see this"}
// {"module":"example","logger":"MyName","trouble":true,"reasons":[0.1,0.11,3.14],"message":"uh oh"}
// {"module":"example","error":"an error occurred","logger":"MyName","code":-1,"message":"goodbye"}
// {"module":"example","v":0,"logger":"MyName","message":"thru a helper"}
// {"level":"info","module":"example","v":0,"logger":"MyName","val1":1,"val2":{"k":1},"message":"hello"}
// {"level":"debug","module":"example","v":1,"logger":"MyName","message":"you should see this"}
// {"level":"error","module":"example","logger":"MyName","trouble":true,"reasons":[0.1,0.11,3.14],"message":"uh oh"}
// {"level":"error","module":"example","error":"an error occurred","logger":"MyName","code":-1,"message":"goodbye"}
// {"level":"info","module":"example","v":0,"logger":"MyName","message":"thru a helper"}
}
3 changes: 0 additions & 3 deletions zerologr.go
Expand Up @@ -72,9 +72,6 @@ func New(l *zerolog.Logger) Logger {

// NewLogSink returns a logr.LogSink implemented by Zerolog.
func NewLogSink(l *zerolog.Logger) *LogSink {
if zerolog.LevelFieldName == "level" {
zerolog.LevelFieldName = ""
}
return &LogSink{l: l}
}

Expand Down

0 comments on commit 92a2ed7

Please sign in to comment.