Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let redis support sentinel #31

Merged
merged 2 commits into from
Feb 24, 2020
Merged

let redis support sentinel #31

merged 2 commits into from
Feb 24, 2020

Conversation

xmh19936688
Copy link
Contributor

let redis support sentinel

@xmh19936688
let redis support sentinel
35dee3b 
let redis support sentinel
@unknwon
Copy link
Contributor

unknwon commented Feb 23, 2020

Thanks for the PR!

I'm not sure familiar with the "Sentinel", can you link a reference?

@xmh19936688
Copy link
Contributor Author

xmh19936688 commented Feb 24, 2020 •
edited
Loading

issue: #26

unknwon
unknwon reviewed Feb 24, 2020
View reviewed changes
Copy link
Contributor

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the link, just one comment/question.

redis/redis.go Show resolved Hide resolved
@unknwon unknwon merged commit 469e6b9 into go-macaron:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unknwon unknwon unknwon left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xmh19936688 @unknwon