Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github.com/go-redis/redis to v8.4.0 #43

Merged
merged 1 commit into from Nov 30, 2020
Merged

Update github.com/go-redis/redis to v8.4.0 #43

merged 1 commit into from Nov 30, 2020

Conversation

6543
Copy link
Contributor

@6543 6543 commented Nov 29, 2020 •
edited

@6543 6543 changed the title Update github.com/go-redis/redis to v8.4.0 Update github.com/go-redis/redis to v6.15.9 Nov 29, 2020
@6543 6543 changed the title Update github.com/go-redis/redis to v6.15.9 Update github.com/go-redis/redis to v7.4.0 Nov 29, 2020
@6543
Copy link
Contributor Author

6543 commented Nov 29, 2020

@unknwon It's ready 🚀

unknwon
unknwon reviewed Nov 29, 2020
View reviewed changes
Copy link
Contributor

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

redis/redis.go Outdated Show resolved Hide resolved
@6543 6543 changed the title Update github.com/go-redis/redis to v7.4.0 [WIP] Update github.com/go-redis/redis to v7.4.0 Nov 29, 2020
@6543
Copy link
Contributor Author

6543 commented Nov 29, 2020

I'll try to migrate to v8 ...

@unknwon unknwon marked this pull request as draft November 29, 2020 15:14
@6543 6543 changed the title [WIP] Update github.com/go-redis/redis to v7.4.0 Update github.com/go-redis/redis to v8.4.0 Nov 29, 2020
@6543 6543 marked this pull request as ready for review November 29, 2020 15:34
@6543
Copy link
Contributor Author

6543 commented Nov 29, 2020

@unknwon it's ready with v8 🎉

I think you have to squash merge ;)

@6543
Copy link
Contributor Author

6543 commented Nov 29, 2020 •
edited

@unknwon or should I squash EDIT: Squashed

@unknwon
Copy link
Contributor

unknwon commented Nov 30, 2020

Thanks, merging!

@unknwon unknwon merged commit 0ae578a into go-macaron:master Nov 30, 2020
@6543 6543 deleted the vendor-fix_redis branch November 30, 2020 01:14
@unknwon
Copy link
Contributor

unknwon commented Nov 30, 2020

https://github.com/go-macaron/session/releases/tag/v1.0.2 has been published for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unknwon unknwon unknwon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@6543 @unknwon