Increase bson.NewObjectId() performance by caching the process id #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every call to
bson.NewObjectId()
will also callsyscall.Getpid()
to obtain the process id. This PR caches the id and increases the performance:AFAIK go does not support process forking, the process id should therefore always be the same.
I noticed this while working on a system that writes a lot of data to the database and generates the ObjectId on the client. This PR significantly increases the performance of the said system.