Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssl detection to ParseURL and test accordingly #304

Open
wants to merge 1 commit into
base: v2-unstable
Choose a base branch
from

Conversation

hcliff
Copy link

@hcliff hcliff commented Jul 22, 2016

This would be a pre-requisite to extending mgo with baked in PEM support etc... but also avoids users having to separately parse their urls to see if connection string uses SSL.

I'd like to keep working on this but:

  1. I'm unclear on the scope of mgo - is a TLS dialer, pem reading/parsing something you'd like to include (I've seen other libraries have a pemFilePath url param)?
  2. I'm having issues getting the test suite to run and as such my tests here are speculative
    here's my supervisord output http://pastebin.com/GqEGFc60

@hcliff hcliff force-pushed the feature/add-ssl-parsing-to-url branch 5 times, most recently from 15648eb to ad96810 Compare July 25, 2016 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant