Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace service prefix with FQDN style prefix #1107

Merged
merged 2 commits into from Jan 12, 2020
Merged

Replace service prefix with FQDN style prefix #1107

merged 2 commits into from Jan 12, 2020

Commits on Jan 12, 2020

  1. Replace service prefix with FQDN style prefix 

    According to the k8s documentation, the label and annotation prefixes should be in the format of a FQDN, with dot separated labels of no more than 63 characters. The current label and annotation paramteres are rejected by the k8s api, most likely because they have two forward slashes in them.
    @ucosty
    ucosty committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    4b112e2 View commit details
    Browse the repository at this point in the history

  2. Use go.micro as service and annotation prefix

    @ucosty
    ucosty committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    9772b4e View commit details
    Browse the repository at this point in the history