Skip to content

Commit

Permalink
Merge pull request #189 from anhoder/master
Browse files Browse the repository at this point in the history
optimize
  • Loading branch information
anhoder committed Sep 3, 2023
2 parents 477dc68 + 046d731 commit 074f359
Show file tree
Hide file tree
Showing 161 changed files with 166 additions and 164 deletions.
14 changes: 7 additions & 7 deletions .goreleaser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ builds:
goos:
- linux
ldflags:
- -s -w -X github.com/go-musicfox/go-musicfox/pkg/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
- -s -w -X github.com/go-musicfox/go-musicfox/internal/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
- id: go-musicfox-linux-arm64
main: ./cmd/musicfox.go
binary: musicfox
Expand All @@ -34,7 +34,7 @@ builds:
- LDFLAGS=-L/usr/aarch64-linux-gnu/lib:$LDFLAGS
- PKG_CONFIG_PATH=/usr/aarch64-linux-gnu/lib/pkgconfig:$PKG_CONFIG_PATH
ldflags:
- -s -w -X github.com/go-musicfox/go-musicfox/pkg/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
- -s -w -X github.com/go-musicfox/go-musicfox/internal/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
- id: go-musicfox-linux-arm
main: ./cmd/musicfox.go
binary: musicfox
Expand All @@ -50,7 +50,7 @@ builds:
- LDFLAGS=-L/usr/arm-linux-gnueabi/lib:$LDFLAGS
- PKG_CONFIG_PATH=/usr/arm-linux-gnueabi/lib/pkgconfig:$PKG_CONFIG_PATH
ldflags:
- -s -w -X github.com/go-musicfox/go-musicfox/pkg/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
- -s -w -X github.com/go-musicfox/go-musicfox/internal/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
- id: go-musicfox-windows-amd64
main: ./cmd/musicfox.go
binary: musicfox
Expand All @@ -59,7 +59,7 @@ builds:
goos:
- windows
ldflags:
- -s -w -X github.com/go-musicfox/go-musicfox/pkg/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
- -s -w -X github.com/go-musicfox/go-musicfox/internal/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
env:
- CC=/usr/local/mingw/bin/x86_64-w64-mingw32-gcc
- CXX=/usr/local/mingw/bin/x86_64-w64-mingw32-g++
Expand All @@ -74,7 +74,7 @@ builds:
goos:
- windows
ldflags:
- -s -w -X github.com/go-musicfox/go-musicfox/pkg/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
- -s -w -X github.com/go-musicfox/go-musicfox/internal/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
env:
- CC=/usr/local/mingw/bin/aarch64-w64-mingw32-gcc
- CXX=/usr/local/mingw/bin/aarch64-w64-mingw32-g++
Expand All @@ -89,7 +89,7 @@ builds:
goos:
- darwin
ldflags:
- -s -w -X github.com/go-musicfox/go-musicfox/pkg/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
- -s -w -X github.com/go-musicfox/go-musicfox/internal/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
env:
- CC=oa64-clang
- CXX=oa64-clang++
Expand All @@ -101,7 +101,7 @@ builds:
goos:
- darwin
ldflags:
- -s -w -X github.com/go-musicfox/go-musicfox/pkg/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/pkg/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
- -s -w -X github.com/go-musicfox/go-musicfox/internal/constants.AppVersion={{.Tag}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmKey={{.Env.LASTFM_KEY}} -X github.com/go-musicfox/go-musicfox/internal/constants.LastfmSecret={{.Env.LASTFM_SECRET}}
env:
- CC=o64-clang
- CXX=o64-clang++
Expand Down
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
PACKAGE_NAME := go-musicfox
GOLANG_CROSS_VERSION ?= v1.21.0
INJECT_PACKAGE ?= github.com/go-musicfox/go-musicfox/pkg/constants
INJECT_PACKAGE ?= github.com/go-musicfox/go-musicfox/internal/constants
LDFLAGS := -s -w
LASTFM_KEY ?=
LASTFM_SECRET ?=
Expand Down Expand Up @@ -85,6 +85,5 @@ release-debug-shell:
-v `pwd`:/go/src/$(PACKAGE_NAME) \
-v `pwd`/sysroot:/sysroot \
-w /go/src/$(PACKAGE_NAME) \
-w /go/src/go-musicfox \
--entrypoint="/bin/bash" \
$(GORELEASER_IMAGE)
2 changes: 1 addition & 1 deletion cmd/musicfox.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package main

import (
"github.com/go-musicfox/go-musicfox/pkg/entry"
"github.com/go-musicfox/go-musicfox/internal/entry"
)

func main() {
Expand Down
2 changes: 1 addition & 1 deletion deploy/nix/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ buildGoModule rec {
ldflags = [
"-s"
"-w"
"-X github.com/go-musicfox/go-musicfox/pkg/constants.AppVersion=${version}"
"-X github.com/go-musicfox/go-musicfox/internal/constants.AppVersion=${version}"
];

nativeBuildInputs = [
Expand Down
2 changes: 1 addition & 1 deletion hack/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ BUILD_GOOS=${GOOS:-$(go env GOOS)}
BUILD_GOARCH=${GOARCH:-$(go env GOARCH)}
GOBINARY=${GOBINARY:-go}
LDFLAGS=${LDFLAGS:-""}
INJECT_PACKAGE=${INJECT_PACKAGE:-"github.com/go-musicfox/go-musicfox/pkg/constants"}
INJECT_PACKAGE=${INJECT_PACKAGE:-"github.com/go-musicfox/go-musicfox/internal/constants"}
LASTFM_KEY=${LASTFM_KEY:-""}
LASTFM_SECRET=${LASTFM_SECRET:-""}
BUILD_TARGET=${BUILD_TARGET:-""}
Expand Down
2 changes: 1 addition & 1 deletion pkg/commands/config.go → internal/commands/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"path"

"github.com/anhoder/foxful-cli/util"
"github.com/go-musicfox/go-musicfox/pkg/constants"
"github.com/go-musicfox/go-musicfox/internal/constants"
"github.com/go-musicfox/go-musicfox/utils"
"github.com/gookit/gcli/v2"
"github.com/muesli/termenv"
Expand Down
6 changes: 3 additions & 3 deletions pkg/commands/netease.go → internal/commands/netease.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import (
"strconv"

"github.com/anhoder/foxful-cli/model"
"github.com/go-musicfox/go-musicfox/pkg/configs"
"github.com/go-musicfox/go-musicfox/pkg/constants"
"github.com/go-musicfox/go-musicfox/pkg/ui"
"github.com/go-musicfox/go-musicfox/internal/configs"
"github.com/go-musicfox/go-musicfox/internal/constants"
"github.com/go-musicfox/go-musicfox/internal/ui"
"github.com/go-musicfox/go-musicfox/utils"
"github.com/mattn/go-runewidth"

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion pkg/configs/registry.go → internal/configs/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

"github.com/anhoder/foxful-cli/model"
tea "github.com/charmbracelet/bubbletea"
"github.com/go-musicfox/go-musicfox/pkg/constants"
"github.com/go-musicfox/go-musicfox/internal/constants"

"github.com/go-musicfox/netease-music/service"
"github.com/gookit/ini/v2"
Expand Down
File renamed without changes.
6 changes: 3 additions & 3 deletions pkg/entry/cli.go → internal/entry/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import (
"log"

"github.com/anhoder/foxful-cli/util"
"github.com/go-musicfox/go-musicfox/pkg/commands"
"github.com/go-musicfox/go-musicfox/pkg/configs"
"github.com/go-musicfox/go-musicfox/pkg/constants"
"github.com/go-musicfox/go-musicfox/internal/commands"
"github.com/go-musicfox/go-musicfox/internal/configs"
"github.com/go-musicfox/go-musicfox/internal/constants"
"github.com/go-musicfox/go-musicfox/utils"

neteaseutil "github.com/go-musicfox/netease-music/util"
Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions pkg/entry/entry_darwin.go → internal/entry/entry_darwin.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ package entry

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/cocoa"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/cocoa"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
"github.com/go-musicfox/go-musicfox/utils"
)

Expand Down
4 changes: 2 additions & 2 deletions pkg/lastfm/api.go → internal/lastfm/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import (
"fmt"
"time"

"github.com/go-musicfox/go-musicfox/pkg/constants"
"github.com/go-musicfox/go-musicfox/pkg/structs"
"github.com/go-musicfox/go-musicfox/internal/constants"
"github.com/go-musicfox/go-musicfox/internal/structs"
"github.com/go-musicfox/go-musicfox/utils"

"github.com/pkg/errors"
Expand Down
File renamed without changes.
File renamed without changes.
3 changes: 3 additions & 0 deletions pkg/lyric/lrc_timer.go → internal/lyric/lrc_timer.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ func (t *LRCTimer) Start() {
transContent = t.transFile.FindByTimeMs(current.StartTimeMs)
isLast = t.curIndex >= len(fragments)-1
)
for _, l := range t.listeners {
l(current.StartTimeMs, current.Content, transContent, isLast, t.curIndex)
}
for {
select {
case <-t.stop:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package avcore

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func init() {
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
"unsafe"

"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func init() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import (
"testing"
"time"

"github.com/go-musicfox/go-musicfox/pkg/macdriver/cocoa"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/cocoa"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func TestMain(m *testing.M) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"unsafe"

"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func init() {
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package cocoa

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func init() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ package cocoa

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func init() {
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ package cocoa

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func init() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package cocoa
import (
"testing"

"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func TestNSImage(t *testing.T) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ package cocoa

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func init() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package cocoa

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func init() {
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

"github.com/ebitengine/purego"
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver"
"github.com/go-musicfox/go-musicfox/internal/macdriver"
)

var (
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package core

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver"
"github.com/go-musicfox/go-musicfox/internal/macdriver"
)

func init() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package core

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver"
"github.com/go-musicfox/go-musicfox/internal/macdriver"
)

func init() {
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package core

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver"
"github.com/go-musicfox/go-musicfox/internal/macdriver"
)

func init() {
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"unsafe"

"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver"
"github.com/go-musicfox/go-musicfox/internal/macdriver"
)

func init() {
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"sync"

"github.com/ebitengine/purego"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

var importOnce sync.Once
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package mediaplayer

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func init() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package mediaplayer

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func init() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package mediaplayer

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func init() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package mediaplayer
import (
"testing"

"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func TestMPFeedbackCommand(t *testing.T) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ package mediaplayer

import (
"github.com/ebitengine/purego/objc"
"github.com/go-musicfox/go-musicfox/pkg/macdriver"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/cocoa"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver"
"github.com/go-musicfox/go-musicfox/internal/macdriver/cocoa"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func init() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ package mediaplayer
import (
"testing"

"github.com/go-musicfox/go-musicfox/pkg/macdriver/cocoa"
"github.com/go-musicfox/go-musicfox/pkg/macdriver/core"
"github.com/go-musicfox/go-musicfox/internal/macdriver/cocoa"
"github.com/go-musicfox/go-musicfox/internal/macdriver/core"
)

func TestMPMediaItemArtwork(t *testing.T) {
Expand Down
Loading

0 comments on commit 074f359

Please sign in to comment.