Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 自动缓存音乐 #139

Merged
merged 9 commits into from
Jul 14, 2023
Merged

feat: 自动缓存音乐 #139

merged 9 commits into from
Jul 14, 2023

Conversation

imxyy1soope1
Copy link
Contributor

添加了自动缓存音乐的功能，在获取歌曲url时会自动搜索缓存，如无缓存会自动下载。
注：如使用mpd,需要在mpd配置中配置music_directory为缓存目录，否则无法播放缓存音乐。

TODO:

  • 添加Mac支持（目前没有Mac开发环境）

anhoder
anhoder reviewed Jul 6, 2023
View reviewed changes
hack/version.sh Outdated Show resolved Hide resolved
anhoder
anhoder requested changes Jul 6, 2023
View reviewed changes
pkg/ui/menu_clear_cache.go Outdated Show resolved Hide resolved
pkg/ui/menu_clear_cache.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
pkg/configs/registry.go Outdated Show resolved Hide resolved
pkg/player/mpd_player.go Show resolved Hide resolved
anhoder
anhoder reviewed Jul 8, 2023
View reviewed changes
Copy link
Member

@anhoder anhoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有冲突需要解决

pkg/configs/registry.go Outdated Show resolved Hide resolved
@imxyy1soope1
fix:
9bc1442 
1. mpd在第一次下载缓存后panic
2. 删除多余的setSongTag调用
3. 修复cacheLimit语义
@imxyy1soope1
mpd强制刷新音乐
17a4db3
@imxyy1soope1
fix: 添加清除音乐缓存在帮助目录的条目
6f831c4
@anhoder
Copy link
Member

anhoder commented Jul 13, 2023

utils还有个冲突
image

@imxyy1soope1
Copy link
Contributor Author

utils还有个冲突 image

改好了
实在抱歉，不知道可以自己修改冲突

@anhoder anhoder merged commit c1c29f9 into go-musicfox:master Jul 14, 2023
@fuyu0425 fuyu0425 mentioned this pull request Jul 14, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhoder anhoder anhoder requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imxyy1soope1 @anhoder