Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GOROOT on init. #22

Merged
merged 1 commit into from Apr 2, 2017
Merged

Setup GOROOT on init. #22

merged 1 commit into from Apr 2, 2017

Conversation

yageek
Copy link
Contributor

@yageek yageek commented Apr 2, 2017

Try to add a start of answer to #21.

I am not a bash guy, so this may not be idiomatic.

Try to add a start of answer to #21.

I am not a bash guy, so this may not be idiomatic.
@yageek yageek closed this Apr 2, 2017
@yageek yageek reopened this Apr 2, 2017
@syndbg syndbg self-requested a review April 2, 2017 10:59
@syndbg
Copy link
Member

syndbg commented Apr 2, 2017

Yeah, good catch. I was having the same issue and was going to submit a PR.

I am not a bash guy, so this may not be idiomatic.

The problem with the solution is that it doesn't actually export the GOROOT as you would expect.

@syndbg syndbg merged commit 8e32646 into go-nv:master Apr 2, 2017
syndbg added a commit that referenced this pull request Apr 2, 2017
@syndbg
Copy link
Member

syndbg commented Apr 2, 2017

@yageek fix regarding string evaluation is in 80fb488

The issue is only in fish shells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants