Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable per-token expiration? #119

Open
dmcinnes opened this issue Aug 9, 2019 · 2 comments
Open

Configurable per-token expiration? #119

dmcinnes opened this issue Aug 9, 2019 · 2 comments

Comments

@dmcinnes
Copy link
Contributor

dmcinnes commented Aug 9, 2019

Hello,

We've been testing this library for a future project but there are a few things that we'd need to add:

  1. The ability to configure a separate expiration duration on a per-token basis.
  2. The ability to configure a 0 duration that means the tokens never expire.

Would you have any objection to us creating a PR to implement these? The 0 duration seems relatively straightforward, for the per-token expiration, I was thinking we'd add support for configuring a function much like SetInternalErrorHandler that would be called on token minting and would return a Duration.

What do you think?

Thanks

@LyricTian
Copy link
Member

Hello, I agree with your request and look forward to your PR.

However, in accordance with your needs, you need to make changes to the token's storage interface and implementation.

@sfwn
Copy link

sfwn commented Mar 22, 2020

maybe you can use AccessTokenExpHandler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants