Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go-swagger/go-swagger#1796 (circular $ref with cycle in remote) #40

Merged
merged 4 commits into from
Nov 17, 2018

Conversation

@fredbi fredbi changed the title Fix go-swagger/go-swagger#1796 (circular $ref with cycle in remote) WIP Fix go-swagger/go-swagger#1796 (circular $ref with cycle in remote) Nov 16, 2018
@codecov
Copy link

codecov bot commented Nov 16, 2018

Codecov Report

Merging #40 into master will decrease coverage by 0.05%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   92.81%   92.76%   -0.06%     
==========================================
  Files           7        7              
  Lines        1643     1659      +16     
==========================================
+ Hits         1525     1539      +14     
- Misses         72       73       +1     
- Partials       46       47       +1
Impacted Files Coverage Δ
flatten.go 85.9% <84.21%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d664ea6...c23ec61. Read the comment docs.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
Copy link
Member Author

fredbi commented Nov 16, 2018

Strange build failure with golangci:

ErrorFailed to load program with go/packages: go [list -e -json -compiled -test=true -export=false -deps=true -- ./...]: exit status 1: go build github.com/go-openapi/jsonpointer: no Go files in
go build github.com/go-openapi/spec: no Go files in
go build github.com/go-openapi/strfmt: no Go files in
go build github.com/go-openapi/swag: no Go files in
"

* Acknowleges go-swagger/go-swagger#1774

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi fredbi changed the title WIP Fix go-swagger/go-swagger#1796 (circular $ref with cycle in remote) Fix go-swagger/go-swagger#1796 (circular $ref with cycle in remote) Nov 16, 2018
@kstedman9
Copy link

@fredbi I pulled your changes locally and rebuilt my complete swagger. It seems to fix the issues I was having with the flattening issue. I will do more work on it this weekend to verify it.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
Copy link
Member Author

fredbi commented Nov 17, 2018

Reported golangci failure: golangci/golangci#25

@fredbi
Copy link
Member Author

fredbi commented Nov 17, 2018

Thanks @kstedman9! You also have a WIP PR on go-swagger which onboards this change and tests some similar issues.

@casualjim casualjim merged commit 5fc8c06 into go-openapi:master Nov 17, 2018
@fredbi fredbi deleted the fix-1796 branch November 17, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants