-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix go-swagger/go-swagger#1796 (circular $ref with cycle in remote) #40
Conversation
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 92.81% 92.76% -0.06%
==========================================
Files 7 7
Lines 1643 1659 +16
==========================================
+ Hits 1525 1539 +14
- Misses 72 73 +1
- Partials 46 47 +1
Continue to review full report at Codecov.
|
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Strange build failure with golangci:
|
* Acknowleges go-swagger/go-swagger#1774 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi I pulled your changes locally and rebuilt my complete swagger. It seems to fix the issues I was having with the flattening issue. I will do more work on it this weekend to verify it. |
Reported golangci failure: golangci/golangci#25 |
Thanks @kstedman9! You also have a WIP PR on go-swagger which onboards this change and tests some similar issues. |
Signed-off-by: Frederic BIDON fredbi@yahoo.com