Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): removes purell from dependancies #11

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

erraggy
Copy link

@erraggy erraggy commented Apr 8, 2022

This adds an internal implementation of what was consumed from the
purell module by copying only the bits that were ultimately
consumed.

All tests still pass.

Issue: #10

This adds an internal implementation of what was consumed from the
`purell` module by copying only the bits that were ultimately
consumed.

All tests still pass.

Issue: go-openapi#10
@casualjim casualjim merged commit c5db558 into go-openapi:master Apr 8, 2022
@erraggy
Copy link
Author

erraggy commented Apr 8, 2022

Thank you for the prompt review/approval/merge! I was curious if a new release tag would be created? Not in a rush, I just wanted to remove the purell dependency from some other projects that depend on this as well.

Thanks again.

@casualjim
Copy link
Member

Thanks for the poke, I pushed a new tag v0.20.0

@erraggy
Copy link
Author

erraggy commented Apr 8, 2022

Oy, and I'm just now realizing my projects pull this in via go-openapi/spec and not directly.
https://github.com/go-openapi/spec/blob/master/go.mod#L5

Not sure how many other go-openapi modules also depend on it. Maybe y'all have a job that bumps dependencies across your modules?

I poked around and only found one other: https://github.com/go-openapi/analysis/blob/master/go.mod#L5

@erraggy
Copy link
Author

erraggy commented Apr 8, 2022

Thanks again @casualjim !!!

I see you've already addressed these and new release tags have been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants