Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting #35

Merged
merged 1 commit into from
Oct 27, 2018
Merged

Linting #35

merged 1 commit into from
Oct 27, 2018

Conversation

fredbi
Copy link
Member

@fredbi fredbi commented Oct 25, 2018

Some effort to keep our repos in line with current coding standards.

Signed-off-by: Frederic BIDON fredbi@yahoo.com

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #35 into master will increase coverage by 17.65%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #35       +/-   ##
===========================================
+ Coverage   70.32%   87.97%   +17.65%     
===========================================
  Files          10       10               
  Lines        1422     1422               
===========================================
+ Hits         1000     1251      +251     
+ Misses        393      144      -249     
+ Partials       29       27        -2
Impacted Files Coverage Δ
default.go 92.81% <ø> (+29.08%) ⬆️
duration.go 96.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edab999...53354ba. Read the comment docs.

* Comply with golangci-lint linting rules
* Refactored unit test to reduce code duplication
* Augmented test coverage

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@casualjim casualjim merged commit 81f5045 into go-openapi:master Oct 27, 2018
@fredbi fredbi deleted the golangci-lint branch October 29, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants