Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples to reflect real US cities #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update examples to reflect real US cities #175

wants to merge 1 commit into from

Commits on Sep 14, 2022

  1. Update examples to reflect real US cities 

    Proposal: 
Update example to validate City length between 1-50.

Reasoning:
For lazy developers like me, I started using this package by copying the examples for the addresses because I figured that they were grounded in real-world, common validation rules. I did tweak the State and Zipcode validation to be more general, but then we hit a snag when we realized that Novi, MI (4 characters) is a real US city. This led me to look into the real boundaries and I've landed on this PR as an enhancement to save headaches for other future lazy developers. :)

Source: 
 https://www.serviceobjects.com/blog/character-limits-in-address-lines-for-usps-ups-and-fedex/ (no minimum, so I assume 1, maximum 50)
    @tuan-nxcr
    tuan-nxcr committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    073390e View commit details
    Browse the repository at this point in the history