Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation rule: min: fix error message #27

Closed
wants to merge 2 commits into from
Closed

validation rule: min: fix error message #27

wants to merge 2 commits into from

Conversation

omeid
Copy link

@omeid omeid commented May 30, 2017

No description provided.

@coveralls
Copy link

coveralls commented May 30, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 00426ce on omeid:patch-1 into d1008ad on go-ozzo:master.

@coveralls
Copy link

coveralls commented May 30, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 0611a22 on omeid:patch-1 into d1008ad on go-ozzo:master.

@qiangxue
Copy link
Member

Could you fix the test error as well? Thanks!

@omeid
Copy link
Author

omeid commented May 30, 2017

No worries, I just looked and the Max rule needs more consideration. I will create a pull request soon.

@qiangxue
Copy link
Member

qiangxue commented Jul 3, 2017

Fixed in 86433d6.

@qiangxue qiangxue closed this Jul 3, 2017
@omeid
Copy link
Author

omeid commented Jul 4, 2017

Thanks for the fix! Sorry, I have been rather busy to wrap this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@omeid @coveralls @qiangxue