Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the "When" rule #96

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Add the "When" rule #96

merged 1 commit into from
Feb 7, 2020

Conversation

mehran-prs
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3f0763a on mehran-prs:master into e04d503 on go-ozzo:master.

qiangxue
qiangxue approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@qiangxue qiangxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much!

@qiangxue qiangxue merged commit 7bf1e8e into go-ozzo:master Feb 7, 2020
@mehran-prs
Copy link
Contributor Author

You're very welcome!

@qiangxue qiangxue mentioned this pull request Feb 7, 2020
Closed
@NathanBaulch
Copy link
Contributor

Should WhenRule implement RuleWithContext just in case any of the rules or elseRules require context? Same with EachRule.

@qiangxue
Copy link
Member

Yes, I think this will be a good enhancement. Created a ticket for this: #129

ltns35 pushed a commit to ltns35/ozzo-validation that referenced this pull request Jun 5, 2022
@mehran-prs
Add When rule. (go-ozzo#96)
2b0daea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiangxue qiangxue qiangxue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mehran-prs @coveralls @NathanBaulch @qiangxue