Protect stats with RWMutex #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yessssssssssssssssssss. |
|
Revisiting this, I think it could be possible to add a unexported uint64 (or int64) for packetsSent and duplicatesrecv. The exported fields can stay there and be updated as they are right now, but they wouldn't be used in Statistics(). |
updateStats() now also updates rtts so it is protected by the lock. Statistics() should now be callable from other goroutines. PacketsSent and PacketsRecvDuplicates can still be updated while Statistics() is running, and thus could yield strange results (sent<recv) To fix this, atomics could be used, but it would require changing the types of the fields from int to int64, thus changing the public api. Signed-off-by: Jean Raby <jean@raby.sh>
|
Rebased |
SuperQ
reviewed
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a request for comments than a proper PR (and it is branched off #150 so only the last commit should be reviewed )
A RWMutex is added to protect access to the Pinger's internal statistics.
Updates to
rttsis moved toupdateStatsso they happen under the lock.There's (at least) one issue however: PacketsSent and PacketsRecvDuplicates can still be updated while
Statistics() is running, and thus could yield strange results (sent<recv)
To fix this, atomics could be used, but it would require changing the types of the fields from int to int64, thus changing the public api of Pinger. (One could argue that those fields should probably not be exported to begin with, but that would break the api too)
Any thoughts?