Always update Packet's addresses #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when one pings multicast addresses to see the actual IPs that replied. There exist multicast addresses for both IPv4 and IPV6 but the lib does not provide the replies address. The output of ping without this patch is: $ sudo ping --privileged ff02::1%ens3 PING ff02::1%ens3 (ff02::1%ens3): 24 bytes from ff02::1%ens3: icmp_seq=0 time=1.504454ms ttl=64 24 bytes from ff02::1%ens3: icmp_seq=0 time=1.553965ms ttl=64 (DUP!) 24 bytes from ff02::1%ens3: icmp_seq=0 time=1.580495ms ttl=64 (DUP!) 24 bytes from ff02::1%ens3: icmp_seq=0 time=1.596156ms ttl=64 (DUP!) And with this patch: $ sudo ./ping --privileged ff02::1%ens3 PING ff02::1%ens3 (ff02::1%ens3): 32 bytes from fe80::546f:f0ff:fe0e:a%ens3: icmp_seq=0 time=1.256761ms ttl=64 32 bytes from fe80::546f:f0ff:fe0e:29%ens3: icmp_seq=0 time=1.396183ms ttl=64 (DUP!) 32 bytes from fe80::546f:f0ff:fe0e:8%ens3: icmp_seq=0 time=1.447454ms ttl=64 (DUP!) 32 bytes from fe80::546f:f0ff:fe0e:e%ens3: icmp_seq=0 time=1.460754ms ttl=64 (DUP!) Which provide more useful informations. Signed-off-by: Gregory Detal <gregory.detal@tessares.net>
|
See #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When a ping is performed on multicast addresses, the lib currently provides the address of the original destination in the callbacks. However, in this case the reply will come from another (existing) address. It is useful to provide the actual replied address to the callback instead of the original one (see the output below).
The output of ping without this patch is:
And with this patch: