Fix panic when k.begin() attempts to return early #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/go-piv/piv-go/blob/master/piv/key.go#L537-L541
The
defer
callstx.Close()
when needed to clean up, however all of the early return paths explicitly returnnil
fortx
, causing a nil dereference panic. This PR has two commits, one with the test case proving the panic and the other with a fix.Another approach could be setting
err = fmt.Errorf(...)
and just doing a bare return at the end.