Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add initial windows support #57

Merged
merged 2 commits into from May 3, 2020
Merged

add initial windows support #57

merged 2 commits into from May 3, 2020

Conversation

tobiaskohlbau
Copy link
Contributor

@tobiaskohlbau tobiaskohlbau commented May 1, 2020 •
edited

Adds support for windows via winscard. This CL leverages the
winscard api via calling into the dll. For more information
see https://docs.microsoft.com/en-us/windows/win32/api/winscard/.

Fixes #56

@tobiaskohlbau tobiaskohlbau force-pushed the feature/addWindowsSupport branch 6 times, most recently from ec80f58 to 95157a5 Compare May 1, 2020 20:34
@tobiaskohlbau
Copy link
Contributor Author

tobiaskohlbau commented May 1, 2020 •
edited

Builders look happy now, sorry for the spam in this CL. The CI-Force is not strong in me 😃.

ericchiang
ericchiang approved these changes May 1, 2020
View reviewed changes
Copy link
Collaborator

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple nits. thanks for the PR!

Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tobiaskohlbau
add initial windows support
e7b0a8b 
Adds support for windows via winscard. This CL leverages the
winscard api via calling into the dll. For more information
see https://docs.microsoft.com/en-us/windows/win32/api/winscard/.

Fixes go-piv#56

Signed-off-by: Tobias Kohlbau <tobias@kohlbau.de>
@tobiaskohlbau
Copy link
Contributor Author

I've addressed your comments. I hope it's fine that I've force pushed. Github is still not working nicely with this workflow, sorry.

@ericchiang
Copy link
Collaborator

I've addressed your comments. I hope it's fine that I've force pushed. Github is still not working nicely with this workflow, sorry.

It looks like the windows build worked fine. Am I seeing something different?

https://github.com/go-piv/piv-go/pull/57/checks?check_run_id=638496144

Will merge this including the workflow if you think it's running correctly

@tobiaskohlbau
Copy link
Contributor Author

Oh I get it my comment is confusing. I referred to the workflow of force pushing which deletes the association between the new code and the old comments.

The GitHub actions workflow run is totally fine.

@tobiaskohlbau
add windows builder
aeec760 
Add windows builder and move to setup-go@v2 as it
supports adding GOPATH/bin to PATH without quirks.

Signed-off-by: Tobias Kohlbau <tobias@kohlbau.de>
@tobiaskohlbau
Copy link
Contributor Author

I've added a build constraint for _unix.go to only build on darwin and linux. Dont know why but I thought unix is supported itself but it's only supported by explicit build constraints as comments.

@tobiaskohlbau tobiaskohlbau mentioned this pull request May 3, 2020
Open
@ericchiang ericchiang merged commit 564f246 into go-piv:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericchiang ericchiang ericchiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support windows via winscard
2 participants
@tobiaskohlbau @ericchiang