Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support LOGIN auth mechanism #15

Merged
merged 15 commits into from
Oct 2, 2022
Merged

feat: support LOGIN auth mechanism #15

merged 15 commits into from
Oct 2, 2022

Conversation

gurza
Copy link
Contributor

@gurza gurza commented Sep 28, 2022

Closes #14

@gurza gurza mentioned this pull request Sep 28, 2022
Closed
umputun
umputun requested changes Sep 28, 2022
View reviewed changes
pkg/smtpauth/smtpauth.go Outdated Show resolved Hide resolved
email.go Outdated Show resolved Hide resolved
email.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
@umputun
Copy link
Member

umputun commented Sep 28, 2022

I have added a few comments, mostly minor things. @paskal pls take a look too, thx

@gurza
Copy link
Contributor Author

gurza commented Sep 29, 2022

@paskal hi! I have resolved all umputun comments. Please review it

@gurza gurza requested a review from umputun September 29, 2022 07:05
umputun
umputun reviewed Sep 29, 2022
View reviewed changes
options.go Outdated Show resolved Hide resolved
@paskal
Copy link
Contributor

paskal commented Sep 29, 2022

I'll review it this evening. In the meantime, could you please run golangci-lint run ./... locally and fix the discovered errors?

@gurza
Copy link
Contributor Author

gurza commented Sep 29, 2022

I'll review it this evening. In the meantime, could you please run golangci-lint run ./... locally and fix the discovered errors?

I have resolved golangci-lint errors. thx

@gurza gurza requested a review from umputun September 30, 2022 04:29
@gurza
Copy link
Contributor Author

gurza commented Sep 30, 2022

@paskal hello!
Have you had a chance to review the code? Any additional comments?

@gurza
Copy link
Contributor Author

gurza commented Oct 1, 2022

@umputun let's merge? )

@umputun
Copy link
Member

umputun commented Oct 1, 2022

@umputun let's merge? )

sure. Just two more things before we merge:

  1. Add info about new auth and a new option to the readme
  2. rebase commits (squash)

@gurza
feat: implement LOGIN auth mechanism
4154868
@gurza
test: cover LoginAuth() with tests
b9c6125
@gurza
feat: support authod method in Sender
5dc6d1d
@gurza
feat: implement authMethod setter
21e692e
@gurza
test: cover Sender.auth with tests
582f323
@gurza
test(ci): include tests in sub-directories
ae1fc33
@gurza
refactor: discard nested package
335018d
@gurza
fix: apply structure changes (no nested pkgs)
376b607
@gurza
refactor: simplify work with auth method
d6480b3 
- use enum
- simplify options interface
@gurza
refactor: simplify auth() method
0603893 
Currently, only two authentication methods are supported.
So for now, switch can be dropped.
@gurza
fix: resolve golangci-lint errors
4660d57
@gurza
refactor: don't export auth mechanism
db1f58a
@gurza
refactor: rename option function
3abcc05 
To be consistent with other options
@gurza
docs: describe new LoginAuth option
7e66aa6
@gurza
docs: extend description of LoginAuth option
5465b15
@gurza gurza changed the title feat: support different auth methods feat: support LOGIN auth mechanism Oct 1, 2022
@gurza
Copy link
Contributor Author

gurza commented Oct 1, 2022

@umputun now this feature branch is rebased and ready to be squashed and merged

@gurza
Copy link
Contributor Author

gurza commented Oct 2, 2022

@umputun I forgot to write right away, I added an info about new auth option to README.md. Looks like you can merge the PR.

@umputun umputun merged commit 19d25a2 into go-pkgz:master Oct 2, 2022
@gurza gurza deleted the feat/login-auth branch October 2, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paskal paskal paskal approved these changes

@umputun umputun Awaiting requested review from umputun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login Auth
3 participants
@gurza @umputun @paskal