add inline (embedded) images support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you have not requested review for any of your current PRs, so I don't check them and treats as some kind of work in progress. In case if you forgot to request and expects me to review - pls let me know |
|
Oh my mistake. @umputun pls check pr |
|
I see nothing wrong with it. If you tested it end-to-end and it worked, I'll merge |
|
Everything seems correct. I have tested e2e with smtp.yandex.com and https://github.com/rnwood/smtp4dev |
|
@umputun do you expect me to do extra tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support image embedding from attachments #3