Rewrite internal cache package for lcw requirements #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umputun
reviewed
May 3, 2020
| if !ok { | ||
| c.data[key] = &cacheItem{} | ||
| } | ||
| c.data[key].data = value |
There was a problem hiding this comment.
I think this assignment can be potentially risky if the value has some sort of mutable elements in, like a slice. Not sure if we should care about ti and perform some deep copy. Probably makes sense to see what other caches do in this case
There was a problem hiding this comment.
go-cache does nothing, gcache provides ability to set serializeFunc but it's not provided out of the box.
There was a problem hiding this comment.
ristretto does nothing as well. Seems to be up to a caller not to shoot himself in a leg.
There was a problem hiding this comment.
ok, let's keep it as-is, but mention it in the readme as something user should be aware of
There was a problem hiding this comment.
#18 created to fix it.
umputun
approved these changes
May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the logic, removing functions calls and storage. Stats removed as they are provided by lcw itself.