Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for distributed cache for LRU and Expirable caches #26

Merged
merged 7 commits into from
Jun 10, 2020

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented May 16, 2020

Adds support of distributed cache invalidation using the PubSub interface. It seems to make sense to implement it only for local LRU and Expirable cache, but not for Redis or SCache.

Test with example Redis implementation is added as well and invoked from CI.

Resolves #8.

@paskal paskal force-pushed the pubsub branch 2 times, most recently from e81fb09 to 8cc4623 Compare May 28, 2020 19:36
cache_test.go Outdated Show resolved Hide resolved
@paskal paskal marked this pull request as draft June 5, 2020 19:46
@paskal paskal marked this pull request as ready for review June 6, 2020 12:51
@paskal paskal requested a review from umputun June 6, 2020 16:20
@paskal paskal removed their assignment Jun 7, 2020
Copy link
Member

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor things

eventbus/redis.go Outdated Show resolved Hide resolved
eventbus/redis.go Outdated Show resolved Hide resolved
eventbus/redis.go Show resolved Hide resolved
expirable_cache.go Show resolved Hide resolved
Copy link
Member

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@umputun umputun merged commit 392920a into master Jun 10, 2020
@umputun umputun deleted the pubsub branch June 10, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic support for distributed cache
2 participants