Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish wrapping into the standard logger #9

Closed
wants to merge 1 commit into from

Conversation

zonescape
Copy link
Contributor

Continuing #7. I think that current implementation of wrapping into the standard logger can be simplified a bit:

  • reduce exported funcs/types to just ToStdLogger()
  • make use of standard logger's prefix

@umputun
Copy link
Member

umputun commented Mar 25, 2019

Having io.Writer adopter can be useful by itself and I've exposed it after some thinking about possible use cases.

@zonescape
Copy link
Contributor Author

I've exposed it after some thinking about possible use cases

Note that current implementation of lgr.Writer relies on this property of log.Logger: "Each logging operation makes a single call to the Writer's Write method". Other clients may not hold this property.

@zonescape zonescape closed this Mar 26, 2019
@zonescape zonescape deleted the polishing-stdlogger branch March 26, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants