Update middleware.go

[RupeshHacker]

fixed issue #27

[coveralls]

Pull Request Test Coverage Report for Build 8136072724

Details

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 88.077%

---

Totals
Change from base Build 8032402702:	0.2%
Covered Lines:	687
Relevant Lines:	780

---

💛 - Coveralls

[umputun]

thx, makes sense. However, the change is missing a corresponding test. I'd suggest smth like this:

func TestWrap(t *testing.T) {
	handler := http.HandlerFunc(func(_ http.ResponseWriter, r *http.Request) {
		t.Logf("%s", r.URL.String())
	})

	mw1 := func(h http.Handler) http.Handler {
		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
			w.Header().Set("X-MW1", "1")
			h.ServeHTTP(w, r)
		})
	}
	mw2 := func(h http.Handler) http.Handler {
		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
			w.Header().Set("X-MW2", "2")
			h.ServeHTTP(w, r)
		})
	}

	t.Run("no middleware", func(t *testing.T) {
		h := Wrap(handler)
		ts := httptest.NewServer(h)
		defer ts.Close()

		resp, err := http.Get(ts.URL + "/something")
		require.NoError(t, err)
		assert.Equal(t, 200, resp.StatusCode)
		assert.Equal(t, "", resp.Header.Get("X-MW1"))
		assert.Equal(t, "", resp.Header.Get("X-MW2"))
	})

	t.Run("with middleware", func(t *testing.T) {
		h := Wrap(handler, mw1, mw2)
		ts := httptest.NewServer(h)
		defer ts.Close()

		resp, err := http.Get(ts.URL + "/something")
		require.NoError(t, err)
		assert.Equal(t, 200, resp.StatusCode)
		assert.Equal(t, "1", resp.Header.Get("X-MW1"))
		assert.Equal(t, "2", resp.Header.Get("X-MW2"))
	})
}

[umputun]

LGTM